Skip to content

Commit d8ecfad

Browse files
committed
Make Popup annotations always have noRotate flag set as true
Necessary because when there is no Popup annotation created along with a Text annotation, the Popup annotation created by pdf.js does not receive the noRotate flag
1 parent 85b67f1 commit d8ecfad

File tree

4 files changed

+10
-0
lines changed

4 files changed

+10
-0
lines changed

src/display/annotation_layer.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -615,6 +615,7 @@ class AnnotationElement {
615615
borderStyle: 0,
616616
id: `popup_${data.id}`,
617617
rotation: data.rotation,
618+
noRotate: true,
618619
},
619620
parent: this.parent,
620621
elements: [this],

test/pdfs/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -611,6 +611,7 @@
611611
!bug1802888.pdf
612612
!issue15759.pdf
613613
!issue18823.pdf
614+
!pr20043.pdf
614615
!issue15753.pdf
615616
!issue15789.pdf
616617
!fields_order.pdf

test/pdfs/pr20043.pdf

90.4 KB
Binary file not shown.

test/test_manifest.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3758,6 +3758,14 @@
37583758
"link": true,
37593759
"type": "eq"
37603760
},
3761+
{
3762+
"id": "pr20043",
3763+
"file": "pdfs/pr20043.pdf",
3764+
"md5": "cdeb98b3229cd44c893c0feaaa3e490f",
3765+
"rounds": 1,
3766+
"type": "eq",
3767+
"annotations": true
3768+
},
37613769
{
37623770
"id": "issue1709",
37633771
"file": "pdfs/issue1709.pdf",

0 commit comments

Comments
 (0)