Skip to content

[Editor] When editing mode is disabled, allow to double click on a added annotation to edit it #20023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2025
Merged

[Editor] When editing mode is disabled, allow to double click on a added annotation to edit it #20023

merged 1 commit into from
Jun 21, 2025

Conversation

calixteman
Copy link
Contributor

It's already possible but only when double clicking outside the the text layer. This patach adds the possibility to click on the text layer.

@calixteman
[Editor] When editing mode is disabled, allow to double click on a ad…
d0b0064 
…ded annotation to edit it

It's already possible but only when double clicking outside the the text layer.
This patach adds the possibility to click on the text layer.
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/68712c17676a593/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1b0378fb84d5f65/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/1b0378fb84d5f65/output.txt

Total script time: 13.65 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/68712c17676a593/output.txt

Total script time: 29.84 mins

  • Integration Tests: FAILED

@timvandermeij
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 1

Live output at: http://54.241.84.105:8877/e63b53f28bd67e5/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/e63b53f28bd67e5/output.txt

Total script time: 1.05 mins

Published

@timvandermeij timvandermeij merged commit ac399e7 into mozilla:master Jun 21, 2025
9 checks passed
@timvandermeij
Copy link
Contributor

Nice improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @timvandermeij