Skip to content

Get the text under highlight/squiggly/underline/strikethrough annotations (bug 1885505) #20019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2025
Merged

Get the text under highlight/squiggly/underline/strikethrough annotations (bug 1885505) #20019

merged 1 commit into from
Jun 22, 2025

Conversation

calixteman
Copy link
Contributor

and add an invisible element containing the text in the annotation layer to make it readable by a screen reader.

@calixteman calixteman changed the title Get the under highlight/squiggly/underline/strikethrough annotations (bug 1885505) Get the text under highlight/squiggly/underline/strikethrough annotations (bug 1885505) Jun 18, 2025
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e003988db7a8ac9/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7609022a04ffef8/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/e003988db7a8ac9/output.txt

Total script time: 32.26 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/7609022a04ffef8/output.txt

Total script time: 57.58 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@calixteman calixteman requested a review from timvandermeij June 19, 2025 14:29
timvandermeij
timvandermeij requested changes Jun 22, 2025
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I'll have a final look at this once the comments are addressed.

@calixteman calixteman force-pushed the bug1885505 branch 2 times, most recently from 71dd42b to 5c14469 Compare June 22, 2025 19:02
timvandermeij
timvandermeij approved these changes Jun 22, 2025
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with the final comments addressed so all test names are consistent and we don't have ambiguity in terminology anymore. Thank you!

@calixteman
Get the text under highlight/squiggly/underline/strikethrough annotat…
3bdc5d5 
…ions (bug 1885505)

and add an invisible element containing the text in the annotation layer to make
it readable by a screen reader.
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/95f3e97082e5045/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/697efbaacb7dd9a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/95f3e97082e5045/output.txt

Total script time: 32.66 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/697efbaacb7dd9a/output.txt

Total script time: 57.32 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@calixteman calixteman merged commit 1ebc896 into mozilla:master Jun 22, 2025
9 checks passed
@calixteman calixteman deleted the bug1885505 branch June 22, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
accessibility annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @timvandermeij