Skip to content

Fix intermittent failure in the find integration tests #20000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2025

Conversation

timvandermeij
Copy link
Contributor

@timvandermeij timvandermeij commented Jun 8, 2025

After clicking the find button we need to wait for the input field to appear before we try to type in it, but instead we were waiting for the button to appear. However, the button is always present, so the current waitForSelector call is basically a no-op, and this can cause the integration tests to fail intermittently if we continue before the input field is actually visible.

This appears to be due a typo first introduced in commit d10da90 that has been copy/pasted.

This commit fixes the issue by waiting for the input field to be visible before we continue typing in it.

Fixes #19999.

After clicking the find button we need to wait for the input field to
appear before we try to type in it, but instead we were waiting for the
button to appear. However, the button is always present, so the current
`waitForSelector` call is basically a no-op, and this can cause the
integration tests to fail intermittently if we continue before the
input field is actually visible.

This appears to be due a typo first introduced in commit
d10da90 that has been copy/pasted.

This commit fixes the issue by waiting for the input field to be visible
before we continue typing in it.
@timvandermeij
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/600601779fed42c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 1

Live output at: http://54.193.163.58:8877/f4e36d35d325a6c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/600601779fed42c/output.txt

Total script time: 13.61 mins

  • Integration Tests: FAILED

@timvandermeij
Copy link
Contributor Author

/botio-linux integrationtest

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@timvandermeij timvandermeij merged commit 250cc7d into mozilla:master Jun 8, 2025
9 of 10 checks passed
@timvandermeij timvandermeij deleted the intermittent-find branch June 8, 2025 20:11
@timvandermeij timvandermeij removed the request for review from Snuffleupagus June 8, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Intermittent failure in the find integration tests
3 participants