Skip to content

Correctly handle files with a hash sign in their names (bug 1894166) #19992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

Correctly handle files with a hash sign in their names (bug 1894166) #19992

merged 1 commit into from
Jun 20, 2025

Conversation

calixteman
Copy link
Contributor

It fixes #19990.

@calixteman calixteman requested a review from Snuffleupagus June 5, 2025 15:19
nicolo-ribaudo
nicolo-ribaudo reviewed Jun 6, 2025
View reviewed changes
@calixteman calixteman requested review from timvandermeij and removed request for Snuffleupagus June 19, 2025 12:10
timvandermeij
timvandermeij approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me; thank you for improving this!

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/48b6edf72d304ce/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ca37b10111a6872/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/48b6edf72d304ce/output.txt

Total script time: 13.34 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/ca37b10111a6872/output.txt

Total script time: 30.14 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3775e75d094f5ec/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e404a6a8c3314b0/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/3775e75d094f5ec/output.txt

Total script time: 2.58 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/e404a6a8c3314b0/output.txt

Total script time: 7.71 mins

  • Unit Tests: Passed

@calixteman calixteman merged commit 84d1703 into mozilla:master Jun 20, 2025
9 checks passed
@calixteman calixteman deleted the hashtag_filename branch June 20, 2025 10:52
@timvandermeij timvandermeij mentioned this pull request Jun 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo left review comments

Assignees
No one assigned
Labels
core viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot display full file name if it contains sharp symbol (#)
4 participants
@calixteman @moz-tools-bot @timvandermeij @nicolo-ribaudo