-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[Editor] Add the possibility to add a popup to an annotation when saving #19976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b92710557233f58/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/bd65ce2204ba4f0/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/bd65ce2204ba4f0/output.txt Total script time: 29.74 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/b92710557233f58/output.txt Total script time: 57.03 mins
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a484cd16b662951/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b21f12f94b94489/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/b21f12f94b94489/output.txt Total script time: 30.28 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/a484cd16b662951/output.txt Total script time: 56.93 mins
|
I'll have another look at this once #20064 is merged and this PR is rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with the comments addressed. Thank you!
When saving/printing, only update the properties which are provided and set a default value only when there is no pre-existing one.
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/d2db69fc584f6af/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/924a039f6e40d03/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/924a039f6e40d03/output.txt Total script time: 31.63 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d2db69fc584f6af/output.txt Total script time: 55.27 mins
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/30cba2ecbe704c6/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d6f5390da3f5c1c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d6f5390da3f5c1c/output.txt Total script time: 16.00 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/30cba2ecbe704c6/output.txt Total script time: 25.16 mins
|
When saving/printing, only update the properties which are provided and set a default value only when there is no pre-existing one.