- 
                Notifications
    You must be signed in to change notification settings 
- Fork 10.4k
[Editor] Disallow to have multiple pointers while dragging an editor #19109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Unfortunately the test isn't failing without the patch and the current version of Puppeteer we use, but with the last one (at least) it's fine. | 
| From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a0d45c9097467f0/output.txt | 
| From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/27afcc9c47c3a9d/output.txt | 
| From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/a0d45c9097467f0/output.txt Total script time: 9.75 mins 
 | 
| From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/27afcc9c47c3a9d/output.txt Total script time: 20.15 mins 
 | 
7dd764e    to
    c7f35df      
    Compare
  
    | /botio integrationtest | 
| From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/456e38e815e0073/output.txt | 
| From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9279ad29564f79c/output.txt | 
| From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/456e38e815e0073/output.txt Total script time: 8.80 mins 
 | 
| From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/9279ad29564f79c/output.txt Total script time: 20.57 mins 
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with a few suggestions to reduce a little bit of duplication; thank you.
6753a3f    to
    710d9a6      
    Compare
  
    | /botio integrationtest | 
| From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 2 Live output at: http://54.241.84.105:8877/b13b5e8d51c9dba/output.txt | 
| From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/6819abaeff0c713/output.txt | 
| From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/b13b5e8d51c9dba/output.txt Total script time: 11.85 mins 
 | 
| From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/6819abaeff0c713/output.txt Total script time: 22.55 mins 
 | 
It'll let the user dragging with two fingers.
710d9a6    to
    e695d04      
    Compare
  
    | /botio integrationtest | 
| From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3a24c1b4d66d932/output.txt | 
| From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e8ee7fa2335aa8c/output.txt | 
| From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/e8ee7fa2335aa8c/output.txt Total script time: 8.81 mins 
 | 
| From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/3a24c1b4d66d932/output.txt Total script time: 19.46 mins 
 | 
It'll let the user dragging with two fingers.