Handle null parentElement for selection anchor #18884
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
selectionchange
handler that's added to the document byTextLayerBuilder
, there is a line which accessesanchor.parentElement.closest(".textLayer")
.This throws an error if
anchor.parentElement
is null, which can happen if the selection is inside a shadow root - I can reproduce it by selecting text inside Grammarly's popover on a page where PDF.is is being used.The error is only seen in non-Firefox browsers, as there is a line which returns earlier in Firefox.
This change handles the
null
parentElement gracefully, to avoid throwing the error.